Fix inline-env-var false positive when expand_argument_vars is used #4587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
audgirka
approved these changes
Apr 23, 2025
When the expand_argument_vars parameter is used on the ansible.builtin.command module, ansible-lint generates a false positive with the inline-env-var rule. The expand_argument_vars parameter was added to the ansible.builtin.command module in ansible-core 2.16 and it appears the inline-env-var lint rule was not updated. This commit updates the inline-env-var rule to support the expand_argument_vars parameter.
f581e27 to
427361f
Compare
ssbarnea
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
expand_argument_varsparameter is used on theansible.builtin.commandmodule, ansible-lint generates a false positive with theinline-env-varrule. Theexpand_argument_varsparameter was added to theansible.builtin.commandmodule in ansible-core 2.16 and it appears theinline-env-varlint rule was not updated. This commit updates theinline-env-varrule to support theexpand_argument_varsparameter.A test was added that fails prior to this change and succeeds after the change.