fix(ui): manually implement close-on-outside-click feature for modals #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. use `pointer-events-auto` to allow backdrop layer to receive event 2. bind a onclick to the backdrop layer
✅ Deploy Preview for chatgpt-demo-v2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ddiu8081
approved these changes
May 10, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🙏 Sorry for not created an Issue before this PR! But I've read what you did in 42c373a, 5691818, and ae35e15 carefully and know what I am doing.
Description
Setting
closeOnOutsideClicktotruecauses two bug:However, there appears to be a simple and straightforward method to implement the desired close-on-outside-click functionality without encountering any issues as mentioned above.
Linked Issues
42c373a, 5691818, and ae35e15
Additional context