fix: support PWA on Netlify #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and update dependencies
✅ Deploy Preview for chatgpt-demo-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1 task
yzh990918
reviewed
Jul 4, 2023
src/layouts/Layout.astro
Outdated
| @@ -39,7 +33,6 @@ const { title } = Astro.props; | |||
| (function() { | |||
| const prefersDark = window.matchMedia && window.matchMedia('(prefers-color-scheme: dark)').matches | |||
| const setting = localStorage.getItem('theme') || 'auto' | |||
| if (setting === 'dark' || (prefersDark && setting !== 'light')) | |||
| document.documentElement.classList.toggle('dark', true) | |||
| if (setting === 'dark' || (prefersDark && setting !== 'light')) document.documentElement.classList.toggle('dark', true) | |||
There was a problem hiding this comment.
This formatting code may need to be removed.
There was a problem hiding this comment.
Copy that. Looks like IDE reformatted the code without my notice. Would be more careful in the future.
There was a problem hiding this comment.
Copy that. Looks like IDE reformatted the code without my notice. Would be more careful in the future.
Fine， Thanks a lot for your work ❤️
yzh990918
approved these changes
Jul 4, 2023
hisune
added a commit
to hisune/anse
that referenced
this pull request
Jul 5, 2023
fix: support PWA on Netlify (anse-app#79)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement #71
Description
PWA now works on Netlify
Linked Issues
#71
Additional context