Don't recalculate remaining steps, conditionally #3849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug report reproduction steps: Create a new profile so that everything is set to default. Create a new card. Click Good. Open deck options and empty learning steps. Save. No go back and put 1m 10m as LS. Go back to the card and it should show 10m on the Good button. Check if old_steps is empty and if it is just use remaining steps for the new_remaining steps. Add test.
dae
reviewed
Mar 10, 2025
rslib/src/card/mod.rs
Outdated
| @@ -490,6 +496,9 @@ impl From<MemoryState> for FsrsMemoryState { | |||
|
|
|||
| #[cfg(test)] | |||
| mod test { | |||
| use crate::prelude::AnkiError; | |||
| use crate::prelude::Collection; | |||
| use crate::prelude::DeckId; | |||
There was a problem hiding this comment.
It's more idiomatic to import crate::prelude::* and/or super::*
Fixed and ready for merge! Thank you! |
|
Thank you too! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug reported on the forums.
Steps to reproduce the bug.
Changes
Add a condition to check if
old_stepsis empty and if it is use theremainingsteps as thenew_remainingsteps. Add a test.Evidence
skipped-learning-steps-fix.mov
close #3699