Fix CmcdData in query parameter mode not sent for manifest requests in DASH #2253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
1 task
|
Thank you for spotting this. I'll send this now for an internal review now. |
tonihei
pushed a commit
that referenced
this pull request
Apr 14, 2025
PiperOrigin-RevId: 741092998 (cherry picked from commit f2fa0f7)
l1068
pushed a commit
to l1068org/media
that referenced
this pull request
Apr 14, 2025
PiperOrigin-RevId: 741092998 (cherry picked from commit f2fa0f7)
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #2252
Same fix is most probably applicable also for HLS (DefaultHlsPlaylistTracker.java) and SS (SsMediaSource.java).