Use tolerances from Anderson & Anderson #1
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than changing
b.T @ y > tol
, this version attempts to use the tolerances from Anderson & Anderson, where tolerances forrho_p
andrho_d
are different from tolerancesrho_A
rho_mu
andtau
/kappa
. (Anderson & Anderson don't seem to specify what tolerance they used forrho_g
?)Result:
test_bug_11617
PASSEDtest_enzo_example_c_with_infeasibility
PASSEDtest_cholesky
andtest_solver_select
) that specify the solver (cholesky: True
orsym_pos: True
) now FAILED, possibly because the new tolerances are too high to be numerically stable with those solvers.