Middleware support #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreizanik
approved these changes
Sep 10, 2023
|
Thanks for your PR |
kodiakhq bot
referenced
this pull request
in weareinreach/InReach
Sep 11, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [cookies-next](https://togithub.com/andreizanik/cookies-next) | [`3.0.0` -> `4.0.0`](https://renovatebot.com/diffs/npm/cookies-next/3.0.0/4.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>andreizanik/cookies-next (cookies-next)</summary> ### [`v4.0.0`](https://togithub.com/andreizanik/cookies-next/releases/tag/v4.0.0) [Compare Source](https://togithub.com/andreizanik/cookies-next/compare/v3.0.0...v4.0.0) #### What's Changed - Add Prettier config by [@​greg2012201](https://togithub.com/greg2012201) in [https://github.com/andreizanik/cookies-next/pull/48](https://togithub.com/andreizanik/cookies-next/pull/48) - Middleware support by [@​greg2012201](https://togithub.com/greg2012201) in [https://github.com/andreizanik/cookies-next/pull/51](https://togithub.com/andreizanik/cookies-next/pull/51) **Full Changelog**: andreizanik/cookies-next@v3.0.0...v4.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/weareinreach/InReach). PR-URL: #760 Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've added support for middleware. Both the
setCookieandgetCookiefunctions now include a guard statement responsible for detecting middleware context. If the guard detects middleware context, methods attached tores.cookieswill be called. I had to install Next v13 as a devDependency because both theNextResponseandNextRequesttypes were too complex to rewrite, and I needed to import those types directly..I would appreciate a code review, and I would be grateful if my changes could be considered for merging.
This pr refers to #12