This repository was archived by the owner on Jun 14, 2022. It is now read-only.
fix QR code not found in image file #792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
- use QRCodeReader instead of MultiFormatReader - use decoding hints with BarcodeFormat.QR_CODE - try a second time with DecodeHintType.TRY_HARDER Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
- update com.google.zxing:core to 3.4.1 Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
flocke
approved these changes
Mar 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try decoding the image multiple times with different decoding hints and update dependency ZXing to version 3.4.1. to FIX #790.
Note: Although the documentation says that from
com.google.zxing:coreversion 3.4.0 and later Java 8, which requires targeting API level 24 or later, is required, using Java 8 desugaring is a possible solution. For details see: https://developer.android.com/studio/write/java8-supportJava 8 desugaring was enabled for andOTP with #544 (commit df6c7cd) and is available since 0.8.0.
I tested this with the Android emulator on API Level 22 and 30.