Skip to content
This repository was archived by the owner on Jun 14, 2022. It is now read-only.

Added feature to hide progress bar and add an instruction if there are no cards in the list #745 #746 #747

Merged
merged 2 commits into from
Feb 3, 2021

Conversation

Ullas-Aithal
Copy link
Contributor

@Ullas-Aithal Ullas-Aithal commented Feb 2, 2021

Added dataset oberver on adapter to hide the progress bar and add an empty view with instructions when the list is empty

@Ullas-Aithal
Copy link
Contributor Author

@flocke , I've added a small instruction "Start adding your tokens by pressing '+' at the bottom" as an empty view when there are no tokens in the list. I've combined #745 and #746 since they were related. Let me know if you want me to split them or remove them or change anything else.

Copy link
Member

@flocke flocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the implementation and only have one small change request regarding the style of the empty state message.

@flocke flocke merged commit bc0a6f9 into andOTP:master Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants