Skip to content
This repository was archived by the owner on Jun 14, 2022. It is now read-only.

Conversation

jsoberg
Copy link
Contributor

@jsoberg jsoberg commented Jan 30, 2021

Sorry, it looks like I actually added this initial bug in commit b0c56b3 (I wasn't setting the input type when switching to password). I changed that, and fixed a few other small bugs that I found while looking at it:

  • Began clearing the input fields when switching auth methods. We weren't doing this before, and you could technically therefore switch from password (entering alpha chars) and back to PIN and save it as long as they matched up. This is an unlikely case that the user would have to actively try to mess up, but it would mean you wouldn't be able to login (since the user would only be presented with a number keyboard when logging in later on).
  • Began hiding the keyboard on proper input when switching auth methods. Before the keyboard wasn't being hidden when choosing none/device.

Also did some simple code cleanup (condensed some methods).

…ady done one line above from the ConfirmedPasswordTransformationHelper call)
Fix bug where keyboard wasn't being hidden when selecting none/device
Not clearing was allowing a potentially weird state where you could have alpha characters in a PIN
@flocke flocke self-assigned this Jan 30, 2021
@flocke flocke added this to the v0.8.1 milestone Jan 30, 2021
@flocke flocke added the bug label Jan 30, 2021
@flocke flocke self-requested a review January 30, 2021 17:24
@flocke flocke merged commit 504e0c8 into andOTP:master Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants