This repository was archived by the owner on Jun 14, 2022. It is now read-only.
#638 - Convert all password views with confirmation field to share toggle state #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…firm password transformation methods
…ion method utility
…mation field to use the password confirmation utility
…eEnabled is now deprecated
|
Thank you a lot for this! I am currently on vacation, but I will review it as soon as I get back. |
|
No problem! Have a good vacation |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a utility for setting input/confirmation password transformation since it's used in multiple places. Converted all views that have a password confirmation to use this utility, so that show/obscure password toggle state is shared between input and confirm.
Tests performed to verify changes:
IntroScreenActivity)CredentialsPreference)PasswordEntryDialog)PasswordEncryptedPreference)