This repository was archived by the owner on Jun 14, 2022. It is now read-only.
#639 Shared Preference NPE Fix #640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at we aren't leaving callbacks to a destroyed activity Make fields in SettingsActivity/SettingsFragment private
92e743c to
7e85594
Compare
…aren't leaving callbacks to a destroyed activity
7e85594 to
28be98e
Compare
|
I realized after I pushed that I accidentally referenced 638 instead of 639 in my commit messages, so I force pushed message rewords for history's sake. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Began unregistering Shared Pref listeners on activities that have been destroyed. This ensures that we aren't getting callbacks to a destroyed activities, and also that we're not potentially modifying shared preferences multiple times (since a new listener would be registered on each activity creation).
Unrelated cleanup, set some fields in SettingsActivity to be private (since they weren't being used elsewhere).