This implements MOTP support #617
Conversation
Update my fork
This has been lagging around due to several things. I have also struggled to get my branch in sync with master, so I have built patches and applied them directly to mater here. Let's see if this time I can finally get this pushed and submit a pull request.
|
I just realised that we had changed defaults at app/src/main/java/org/shadowice/flocke/andotp/Activities/IntroScreenActivity.java and that is probably something that you don't want. Sorry about that. |
Rewrite MD5 calculator to use Java's md5 implementation Remove MD5.java
|
Ok, I have reviewed it again and have returned to your defaults and also removed the MD5 implementation and recoded it based on Java's one. |
|
I will look over the code in the next couple of days (hopefully). |
|
Restored all language files and commited it, hope that fits what you wanted. |
There was a problem hiding this comment.
I reviewed the code and found some parts that needed changing. Most of those were introduced by changes I made to the codebase after you already submitted the pull request.
I fixed them locally and created a patch file you can use to update your branch: 0001-Make-MOTP-work-with-the-newest-andOTP-codebase.patch.txt
I will merge the pull request after you add those changes.
I also included some minor improvements (like using the Hex class from Apache Commons Codec for all Hex-related functions and validating the secret when manually entering it).
We had to add pin input and some other stuff.