Skip to content
This repository was archived by the owner on Jun 14, 2022. It is now read-only.

#149 English String suggestions #576

Merged
merged 8 commits into from
Jun 9, 2020

Conversation

jsoberg
Copy link
Contributor

@jsoberg jsoberg commented May 31, 2020

Some suggested changes to English strings, referencing #149

jsoberg added 5 commits May 31, 2020 19:00
Add commas where (seemingly) appropriate, for better flow
Specify andOTP (or the appropriate subject) in some cases instead of "the" or "it"
Use the term "hardware-based encryption" instead of "hardware cryptography"
Use a comma in first sentence for better flow
Change "only stores them in encrypted data files" to "andOTP uses encryption to store account data"
Separate the initial sentence into two separate sentences for better flow
Use "Please pay attention and read carefully to avoid losing data"; this is subjective, but it seems to flow better than the original sentence
Mostly rewording the "advantage" sentence to flow better
Use "setup and authentication method" instead of "setup an authentication"
Add "your" before "encryption method" to sound more natural, and add a comma for better flow
@flocke flocke self-assigned this Jun 1, 2020
@flocke flocke added this to the v0.8.0 milestone Jun 1, 2020
jsoberg added 3 commits June 1, 2020 20:11
Use "be lost" instead of "get lost" in first sentence
Modify second sentence to sound more natural
The original sentence was fine as is, but moving the "now" seems to sound more natural
@jsoberg jsoberg marked this pull request as ready for review June 2, 2020 00:39
@flocke flocke merged commit 9070f90 into andOTP:master Jun 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants