This repository was archived by the owner on Jun 14, 2022. It is now read-only.
Fixes #569 - Validate expected Integer input for the Digits and Perio… #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Period fields, and expected Long input for the Counter field
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d fields, and expected Long input for the Counter field
Since this is a strange/unexpected edge case, I thought that validating the Integer/Longs as expected values when enabling the save button would be sufficient. Let me know if you'd like me to do further validation, e.g. setting errors on the appropriate edit texts.
This validation ensures that we'll be getting expected values in the save button's onClick, but if you'd like me to add additional validation there just let me know.