first step towards 0.8.0 by ziegenberg · Pull Request #544 · andOTP/andOTP · GitHub

This repository was archived by the owner on Jun 14, 2022. It is now read-only.

Contributor

ziegenberg commented May 8, 2020 •

edited

Loading

Updating build environment, tools and dependencies

update gradle to 6.4
fixing some build warnings

Updating documentation

updating readme reflecting changes in tools and dependencies
updating changelog reflecting changes in tools and dependencies
updating copyright notes

rebasing onto master from time to time

ziegenberg marked this pull request as draft

May 8, 2020 01:52

Contributor Author

ziegenberg commented May 8, 2020

The build passed after fixing the travis config: https://travis-ci.org/github/andOTP/andOTP/builds/684514545

ziegenberg force-pushed the update-gradle branch from 4e0c52b to d00db97 Compare

May 13, 2020 16:22

Contributor Author

ziegenberg commented May 13, 2020

@flocke are those changes you would actually favour, or are they not desired?

flocke self-assigned this

flocke added this to the v0.8.0 milestone

flocke added the enhancement label

ziegenberg force-pushed the update-gradle branch from d00db97 to 6f52906 Compare

May 18, 2020 21:25

ziegenberg force-pushed the update-gradle branch from 6f52906 to 182cc0f Compare

May 28, 2020 19:55

Contributor Author

ziegenberg commented May 28, 2020

rebased onto current master

Contributor Author

ziegenberg commented May 29, 2020

Build Zeiten sind jetzt bei ca. 1 Sekunde, wenn die Build Caches genutzt werden.

Member

flocke commented Jun 9, 2020

@ziegenberg I merged the storage_access branch to master, which included some of my own first adaptions for 0.8.0. So some of the changes in this PR are now redundant, but I am still interested in a lot of the other stuff you added. If you want you can now rebase it, mark it ready for review and I will merge it as soon as possible.

ziegenberg force-pushed the update-gradle branch 2 times, most recently from 42a6edc to 30f16fa Compare

June 9, 2020 15:16

ziegenberg marked this pull request as ready for review

June 9, 2020 16:09

ziegenberg added 14 commits

June 9, 2020 18:17


          update gradle to 6.4

a279af2

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>


          (FIX) update year to current in copyright in license file

f225786

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>


          Update README to reflect changes in minimum supported Android Version

ffce377

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>


          use build caching for faster builds and output gradle warning

65b89bd

use newline at end of file

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>


          use linting in debug builds

98e4bce

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>


          DSL element 'android.dataBinding.enabled' is obsolete and has been re…

ed01237

…placed with 'android.buildFeatures.dataBinding'.

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>


          Java 8 library desugaring in D8 and R8

df6c7cd

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>


          (FIX) update year to current in copyright in license file

2a78396

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>


          Variable 'encryptionKey' initializer 'null' is redundant

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>


          replace anonymous new EncryptionFragment.EncryptionChangedCallback() …

ad8504e

…with lambda

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>


          replace anonymous new OnNavigationBlockedListener() with lambda

59bce32

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>


          min API Level was set to 22 (Lollipop 5.1)

3402c04

toast message for pre lollipop no longer needed

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>


          cleanup and remove unused toast message for backup directory

162e112

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>


          update CHANGELOG.md

a6441a1

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>

ziegenberg force-pushed the update-gradle branch from 8881511 to a6441a1 Compare

June 9, 2020 16:19

ziegenberg changed the title ~~[WIP] first step towards 0.8.0~~ first step towards 0.8.0

ziegenberg requested a review from flocke

June 9, 2020 16:22

Contributor Author

ziegenberg commented Jun 9, 2020

Build runs through and succeeds. Although it produces a myriad of build warnings we can now work on.

flocke approved these changes

View reviewed changes

Member

flocke left a comment

Looks good to me. Although you don't have to touch the translations, they get overwritten again when I merge the translations from Crowdin. It's enough if we just change the English version.

flocke merged commit e2de15e into andOTP:master

ziegenberg deleted the update-gradle branch

June 10, 2020 13:43

ziegenberg mentioned this pull request

fix QR code not found in image file #792

Merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels