This repository was archived by the owner on Jun 14, 2022. It is now read-only.
This repository was archived by the owner on Jun 14, 2022. It is now read-only.
App crashes if incorrect secret is entered #500
Description
General information
- App version: 0.7.0
- App source: built from sources
- Android Version: Android 9
- Custom ROM: emulator
Same crash on actual devices with app 0.7.0 and 0.6.3.1 from F-Droid.
Expected result
What is expected?
An error message is displayed.
What does happen instead?
App crashes.
Logcat
org.shadowice.flocke.andotp.dev E/AndroidRuntime: FATAL EXCEPTION: main
Process: org.shadowice.flocke.andotp.dev, PID: 3414
java.lang.IllegalArgumentException: Last encoded character (before the paddings if any) is a valid base 32 alphabet but not a possible value. Expected the discarded bits to be zero.
at org.apache.commons.codec.binary.Base32.validateCharacter(Base32.java:577)
at org.apache.commons.codec.binary.Base32.decode(Base32.java:404)
at org.apache.commons.codec.binary.BaseNCodec.decode(BaseNCodec.java:482)
at org.apache.commons.codec.binary.BaseNCodec.decode(BaseNCodec.java:465)
at org.shadowice.flocke.andotp.Database.Entry.<init>(Entry.java:90)
at org.shadowice.flocke.andotp.Dialogs.ManualEntryDialog$7.onClick(ManualEntryDialog.java:210)
at com.android.internal.app.AlertController$ButtonHandler.handleMessage(AlertController.java:172)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:193)
at android.app.ActivityThread.main(ActivityThread.java:6669)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
Steps to reproduce
- Open entry creation dialog ("+" -> Enter details).
- Enter "test" in the "Secret" field (and fill other required fields).
- Press "Save".