Skip to content
This repository was archived by the owner on Jun 14, 2022. It is now read-only.
This repository was archived by the owner on Jun 14, 2022. It is now read-only.

Issuer is not stripped from the label when adding via URL / QR Code #551

@SagePtr

Description

@SagePtr

General information

  • App version: 0.7.0-play, 0.7.1-beta2
  • App source: Google Play, GitHub
  • Android Version: 5.1
  • Custom ROM:

Expected result

What is expected?
Label should not include issuer name, only username, as issuer is stored separately.
Should look: issuer - username

What does happen instead?
Label includes issuer name, so it's duplicated.
It looks: issuer - issuer:username

Steps to reproduce

Scan any QR code with openauth:// url made by this recommendation from Google. The link has format:
otpauth://totp/Example:username?secret=AABBCCDDEEFFGGHH&issuer=Example
Here is example QR code with above link encoded:
example-totp-qr

The recommendation says:

If you encounter encoded URIs where the issuer name appears in the prefix as well as a URI parameter, consider stripping the issuer name in the UI and branding accordingly.

So, according to it, issuer should be "Example" and username should be "username" with issuer stripped from it.
Instead of this, we get "Example" as issuer name (correct) and "Example:username" as label (incorrect).
It doesn't matter whenever QR Code was scanned inside andOTP, or scanned with internal application and passed link into andOTP, so it looks that issue is related to URL parsing, not QR code recognition.

Here is screenshot how it looks (i made screenshot with emulator because andOTP prevents from making screenshots, but on actual hardware it looks the same:
image

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions