Skip to content

Component Shim #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Component Shim #715

wants to merge 3 commits into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Feb 19, 2015

  • shim css is now a port from webcomponents.js
    • it will be easier to backport fixes from there,
    • we could also contribute bug fixes there.
  • The shim would work whatever the component selector is (the former version for only with tag names)

This PR fixes the 2 first bullet points of #669

@vicb vicb force-pushed the 0217-cssshim branch 2 times, most recently from 58a59c4 to 3429a42 Compare February 19, 2015 17:21
@mhevery mhevery added @lgtm action: merge The PR is ready for merge by the caretaker labels Feb 19, 2015
@vicb vicb closed this in d0ca07a Feb 19, 2015
@vicb vicb removed the in progress label Feb 19, 2015
@vicb vicb mentioned this pull request Feb 20, 2015
Closed
4 tasks
@vicb vicb deleted the 0217-cssshim branch December 3, 2015 16:53
@trotyl trotyl mentioned this pull request Nov 4, 2018
Closed
@JiaLiPassion JiaLiPassion mentioned this pull request Jul 21, 2019
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vicb @vsavkin @mhevery @googlebot