fix(router): navigate to root if initial navigation fails #46648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Edit: Just one failure that is a screenshot test showing the new correct behavior. The old screenshot showed just a blank screen (plus the app header) with an error popup. |
43522ab to
94ffa50
Compare
There was a problem hiding this comment.
@atscott looks great, just a couple comments on potential DX improvement and a corner case when navigation to / also fails.
When a navigation in the router fails, we reset the internal state and browser URL to the last successful navigation. For the initial navigation, this does not exist, so `''`/`'/'` is used. Prior to this commit, the state reset was not also accompanied by a navigation to the root of the application. This results in a "blank" screen (or rather, it only shows content that is outside the `router-outlet` such as the static app header). With this commit, the router initializer, which includes an `initialNavigation` call, now tracks whether the initial navigation succeeded (including redirects). If the navigation did not succeed, a navigation to the root of the application is triggered (`'/'`). Again, this is in addition to what the router already does for this failed navigation: setting its internal state and browser URL to the root. Fixes angular#16211
AndrewKushnir
approved these changes
Jul 7, 2022
sonukapoor
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a navigation in the router fails, we reset the internal state and
browser URL to the last successful navigation. For the initial
navigation, this does not exist, so
''/'/'is used. Prior to thiscommit, the state reset was not also accompanied by a navigation to the
root of the application. This results in a "blank" screen (or rather, it
only shows content that is outside the
router-outletsuch as thestatic app header).
With this commit, the router initializer, which includes an
initialNavigationcall, now tracks whether the initial navigation succeeded (including
redirects). If the navigation did not succeed, a navigation to the root
of the application is triggered (
'/'). Again, this is in addition towhat the router already does for this failed navigation: setting its internal
state and browser URL to the root.
Fixes #16211