Skip to content

Conversation

camisowers
Copy link
Contributor

@camisowers camisowers commented Apr 9, 2024

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Closes #1129.
Fixes generate_and_save_neighborhood_cluster_masks() call in the kmeans notebook.

How did you implement your changes

Adds argument keywords to avoid incorrect ordering.

Remaining issues

N/A

@camisowers camisowers added the bug Something isn't working label Apr 9, 2024
@camisowers camisowers self-assigned this Apr 9, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@srivarra srivarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@camisowers camisowers added this pull request to the merge queue Apr 10, 2024
Merged via the queue into main with commit da4013c Apr 10, 2024
@camisowers camisowers deleted the kmeans_nb_plotting branch April 10, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate neighborhood mask results in string error
2 participants