-
Notifications
You must be signed in to change notification settings - Fork 30
General CI Updates #1114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General CI Updates #1114
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's slay this beast for good.
Why does updating to alpineer v0.1.12 not cause issues the same way it did in toffy? angelolab/alpineer#43 |
@camisowers I'm unable to replicate that issue occurring in Toffy. For example I ran the following on the example data: io_utils.list_files(dir_name = os.path.join(base_dir, "image_data", "fov0"), substrs=".tiff") And the I got the expected output: Output['CD14.tiff',
'H3K27me3.tiff',
'HLADR.tiff',
'Ki67.tiff',
'Collagen1.tiff',
'CD45.tiff',
'GLUT1.tiff',
'CK17.tiff',
'CD68.tiff',
'CD163.tiff',
'Fibronectin.tiff',
'Vim.tiff',
'CD8.tiff',
'CD4.tiff',
'H3K9ac.tiff',
'ECAD.tiff',
'SMA.tiff',
'CD31.tiff',
'IDO.tiff',
'CD20.tiff',
'PD1.tiff',
'CD3.tiff'] Is there a specific combination of arguments which causes trouble? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also tested it and using substs=['.tiff']
in the alpineer v0.1.12 list_files()
function doesn't seem to cause an issue! (Not sure why the toffy functions are failing.)
PR looks good to me.
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Fixes several issues plauging CI.
./github/scripts/get_example_dataset.py
download script.How did you implement your changes
Example Dataset
Simplified the CI download script.
conftest.py
directly access theGITHUB_WORKSPACE
environment variable which is set in CI, thus making the path OS agnostic.Modified the
example_dataset.ExampleDataset
class to:cache_dir
to the HuggingFace default~/.cache/huggingface/datasets
ifNone
is provided.dataset_paths
fromDatasetDict
to a regular dictionary in order to make the example datasets to be OS agnostic, and it's easier to access the paths.For example:
'/Users/user/.cache/huggingface/datasets/downloads/extracted/<hash>'
'pathlib.path(self.dataset_cache) / downloads/extracted/<hash>/<feature_name>'
CI
GITHUB_WORKSPACE
as an environment variable in CI.macos-latest
(wherelatest
is12
) tomacos-13
v3
v4
v2
v3
v2
v3
v2
v3
v4
v5
v4
v5
v2.13
v2.16
v3
v4
v3
v5
v3
v4
v1.6
v1.8
coverage-<python version>-<runner>
, (e.x. coverage-3.9-windows-latest.lcov, artifact has the same name).main
, wheremacos-13
status checks for test and build are required. Removedmacos-latest
status checks.Dependencies
Updated the following:
alpineer
:0.1.10
0.1.12
Cython
:0.29.Z
>3.Y.Z
(for both buld-system and dependencies)pyFlowSOM
:0.1.15
0.1.16
scikit-image
:<=0.19.3
<0.19.3
(0.19.3
causes issues)The valid datset configs are gathered from the HuggingFace repo itself now, and
.github/scripts/get_example_dataset.py
is simplified.Pixel Clsutering
Adds
natsort
calls throughout the Pixie pipeline to avoid issues with channel ordering.Removed the parameter
channels
inpixel_som_clustering.py::cluster_pixels
as it is an unused parameter. Reflected the change in Notebook 2.Misc
Adjusted the runtime Protocol definition for
ClusterClassTemplate
to be syntactically correct.Removed a few
cibuildwheel
flags that are not needed.Remaining issues
CI / Dependencies
cibuildwheel
.numpy
to make use of these runners, however this requires us to drop thespatial-lda
requirement as it is not compatible withnumpy
versions1.24
and newer.scikit-image
also require the more recentnumpy
versions, therefore we would need to updatescikit-image
to0.20
or later. Requires us to re-address Bad filtering in fiber segmentation #1055.numpy
1.23+
is deprecated.numpy
is limited to1.24+
. (spatial-lda
andscikit-image
hinder this one)Dataset
There have been several improvements to the general dataset workflow with the HuggingFace API. We should consider seeing what new features exist to make the maintenance of it easier for us.