Skip to content

Only load whole cell masks if nuclear_counts=False in generate_cell_table #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2024

Conversation

alex-l-kong
Copy link
Contributor

What is the purpose of this PR?

Closes #1097. Updates generate_cell_table to be compatible with updated ezSeg pipeline when nuclear masks need to be discarded.

How did you implement your changes

By default, the updated generate_cell_table loads in all the masks, including nuclear, and adds them to the cell table. For pixel clustering, only the whole cell data is needed, so if nuclear_counts=False, this mask type should not appear in the table.

Remaining issues

Integration testing with Pixie/Nimbus needed.

@alex-l-kong alex-l-kong self-assigned this Jan 18, 2024
@alex-l-kong alex-l-kong requested a review from cliu72 January 22, 2024 22:01
Copy link
Contributor

@cliu72 cliu72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@alex-l-kong alex-l-kong added this pull request to the merge queue Feb 24, 2024
Merged via the queue into main with commit 63ee8ff Feb 24, 2024
@alex-l-kong alex-l-kong deleted the separate_nuc_wc branch February 24, 2024 00:36
@srivarra srivarra added the bug Something isn't working label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Even when setting nuclear_counts = False, nuclear masks are being quantified in marker_quantification.generate_cell_table
3 participants