Skip to content

Conversation

camisowers
Copy link
Contributor

@camisowers camisowers commented Jul 10, 2023

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Closes #1019.
Adds progress bars for neighbors matrix generation, diversity analysis, and cell distance analysis. Also adds a fov description to the distance matrix progress bar.

How did you implement your changes

Use tdqm package.

Remaining issues

Any suggestions for other places in ark that could use a progress bar?

@camisowers camisowers added the enhancement New feature or request label Jul 10, 2023
@camisowers camisowers self-assigned this Jul 10, 2023
@camisowers camisowers marked this pull request as ready for review July 10, 2023 22:03
Copy link
Contributor

@srivarra srivarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a suggestion to improve the user experience.

Copy link
Contributor

@alex-l-kong alex-l-kong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sri covered it all, nothing else to add.

@camisowers camisowers requested a review from ngreenwald July 11, 2023 00:44
Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngreenwald ngreenwald merged commit b645e03 into main Jul 11, 2023
@ngreenwald ngreenwald deleted the spatial_progress_bars branch July 11, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress bars for spatial analysis
4 participants