Allow FOVs to contain various maximum clusters #1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of just per cell)
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
camisowers
reviewed
Jun 30, 2023
alex-l-kong
approved these changes
Jun 30, 2023
ngreenwald
requested changes
Jun 30, 2023
ngreenwald
approved these changes
Jul 5, 2023
cliu72
reviewed
Jul 6, 2023
cliu72
reviewed
Jul 6, 2023
cliu72
reviewed
Jul 6, 2023
cliu72
reviewed
Jul 6, 2023
cliu72
reviewed
Jul 6, 2023
cliu72
reviewed
Jul 6, 2023
cliu72
reviewed
Jul 6, 2023
cliu72
reviewed
Jul 6, 2023
cliu72
reviewed
Jul 6, 2023
cliu72
requested changes
Jul 6, 2023
cliu72
reviewed
Jul 7, 2023
cliu72
reviewed
Jul 20, 2023
cliu72
reviewed
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Keeps the segmentation consistent across all FOVs in a cohort, even if a FOV does not have a particular phenotype / cluster when compared to others in its cohort.
Adds the fix for cell clustering, neighborhood clustering, and for Mantis ingestion.
How did you implement your changes
Created a new dataclass
CellClusterMaskDatawhich contains all the cell data, cluster column, segmentation column for a particular cohort (or all FOVs used for the cell table).Remaining issues
Partially addresses #857.