Skip to content

Conversation

srivarra
Copy link
Contributor

@srivarra srivarra commented Jul 17, 2023

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Allows the Ubuntu Test Runner to not run out of storage space.

How did you implement your changes

Adds more shutil.rmfree function calls in the example dataset tests and adjusts those in the notebook tests. Adjusts the Test_Cell_Neighbors notebook to make use of the cached dataset on GHA. Added a decorator which can be used throughout the example dataset notebook tests to get info about storage space on the runner. For example:

class Test_1_Segment_Image_Data:
    """
    Tests Notebook 1 - Segment Image Data for completion.
    NOTE: When modifying the tests, make sure the test are in the
    same order as the tagged cells in the notebook.
    """
	.
	.
	.
	@notebooks_test_utils.get_storage
    def test_ex_data_download(self):
        notebooks_test_utils._ex_dataset_download(dataset=self.dataset, save_dir=self.base_dir,
                                                  cache_dir=self.cache_dir)

	.
	.
	.

Remaining issues

None.

@srivarra srivarra linked an issue Jul 17, 2023 that may be closed by this pull request
@srivarra srivarra changed the title Maximize GitHub Storage Space Maximize Available GitHub Storage Space Jul 18, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@srivarra srivarra self-assigned this Jul 19, 2023
@srivarra srivarra added github_actions Pull requests that update GitHub Actions code bug Something isn't working and removed github_actions Pull requests that update GitHub Actions code labels Jul 19, 2023
@srivarra srivarra marked this pull request as ready for review July 19, 2023 21:17
Copy link
Contributor

@camisowers camisowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just a clarifying question about get_storage().

@srivarra srivarra added this pull request to the merge queue Jul 20, 2023
@srivarra srivarra removed this pull request from the merge queue due to a manual request Jul 20, 2023
Copy link
Contributor

@alex-l-kong alex-l-kong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@srivarra srivarra added this pull request to the merge queue Jul 20, 2023
Merged via the queue into main with commit 6a7c313 Jul 20, 2023
@srivarra srivarra deleted the github_actions/build_storage_space branch July 20, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ubuntu Linux GHA Runner caps the provided Storage
3 participants