-
Notifications
You must be signed in to change notification settings - Fork 30
Mixing score default thresholds #1015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # templates/Calculate_Mixing_Scores.ipynb
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking goood, just a np.nan
filtering suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice stuff
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
After testing the mixing score on 100 images and across various populations, we determined that total cell count was more useful to restrict rather than counts for the individual populations. As a result, we need to be more restrictive with the ratio of cells that we allow. The defaults that seem to work best are
ratio_threshold=5
andcell_count_thresh=200
.For plotting the ratios in the mixing notebook, we should drop any bigger than 15. Large ratio values just mess with the x axis and makes the plots hard to interpret.

How did you implement your changes
Change the threshold default values in both the notebook and the code. For the output file, only return one
cell_ratio
value per image, instead of both the pop1/pop2 ratio and pop2/pop1 ratio.Adjust the notebook to
Remaining issues
N/A