Skip to content

Conversation

camisowers
Copy link
Contributor

@camisowers camisowers commented Jun 14, 2023

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Besides density measurements, only fiber alignment and length are averaged and stored in the summary stats / tile stats files. We would like to calculate averages for all stats included in the original fiber table.

How did you implement your changes

Compute and save averages for fiber width, orientation, area, eccentricity, euler number.

Remaining issues

N/A

@camisowers camisowers added the enhancement New feature or request label Jun 14, 2023
@camisowers camisowers self-assigned this Jun 14, 2023
@camisowers camisowers marked this pull request as ready for review June 14, 2023 22:01
@camisowers camisowers requested a review from srivarra June 14, 2023 22:01
Copy link
Contributor

@srivarra srivarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a potentially an unused variable in enumerate.

@camisowers camisowers requested a review from srivarra June 14, 2023 22:34
@camisowers camisowers requested a review from ngreenwald June 14, 2023 23:03
Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ngreenwald ngreenwald merged commit e2fa387 into main Jun 15, 2023
@ngreenwald ngreenwald deleted the additional_fiber_properties branch June 15, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants