Add fallback protection to Pixie cell clustering #999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rite functionality for SOM assignment and consensus clustering
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
srivarra
reviewed
May 26, 2023
| @@ -297,7 +297,9 @@ | |||
| "cell_type": "markdown", | |||
There was a problem hiding this comment.
Line #15. compression='uncompressed'
I looked at an issue you investigated a while back, #860 about feather alternatives. It seemed that you concluded that feather files are pretty solid, and they have efficient compression, but they it seems to lack on the actual storage savings side of things. Do you think it may be worth revisiting the compression aspect to see if zstd on the scale of a cohort would be beneficial?
Reply via ReviewNB
There was a problem hiding this comment.
Definitely worth looking into in the near future.
srivarra
approved these changes
May 26, 2023
cliu72
reviewed
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
Closes #992. Because cell clustering now takes a considerable amount of time, chance of intermediate failure also increases. There is no current way to recover intermediate cell training data if this happens, so this needs to be added.
How did you implement your changes
overwritefunctionality to the cell SOM assignment and cell consensus clustering functions. This will allow the user to redo these if they use different parameters.