Skip to content

Pixel Clustering - Run without segmentaiton files #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 17, 2023
Merged

Pixel Clustering - Run without segmentaiton files #998

merged 1 commit into from
May 17, 2023

Conversation

srivarra
Copy link
Contributor

@srivarra srivarra commented May 17, 2023 •
edited
Loading

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Allows pixel clustering without segmentation files.

How did you implement your changes

Added a variable called pixie_seg_dir which evaluates to the full path of the segmentation_dir if it exists, or None when segmentation_dir is None.

Slightly modified a check for None in pixie_preprocesing.py.

Remaining issues

None.

@srivarra srivarra linked an issue May 17, 2023 that may be closed by this pull request
Make it easier if segmentation_dir=None in pixel clustering notebook #996
Closed
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@srivarra srivarra self-assigned this May 17, 2023
@srivarra srivarra added the bug Something isn't working label May 17, 2023
@srivarra srivarra marked this pull request as ready for review May 17, 2023 00:46
@srivarra srivarra requested review from cliu72 and alex-l-kong May 17, 2023 00:46
cliu72
cliu72 approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@cliu72 cliu72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@srivarra srivarra mentioned this pull request May 17, 2023
Merged
4 tasks
@srivarra srivarra added this pull request to the merge queue May 17, 2023
Merged via the queue into main with commit bd42e63 May 17, 2023
@srivarra srivarra deleted the pixie/no_seg_dir branch May 17, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cliu72 cliu72 cliu72 approved these changes

@alex-l-kong alex-l-kong Awaiting requested review from alex-l-kong

Assignees

@srivarra srivarra

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it easier if segmentation_dir=None in pixel clustering notebook
2 participants
@srivarra @cliu72