Mantis Directory with no segmentation files #994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-l-kong
approved these changes
May 16, 2023
| @@ -2,7 +2,7 @@ | |||
| import pathlib | |||
| import shutil | |||
| from operator import contains | |||
| from typing import List, Union | |||
| from typing import List, Optional, Union | |||
There was a problem hiding this comment.
More type checking options, I like 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Closes #969. Adds the ability to not move segmentation files.
How did you implement your changes
Added a flag to check and see if either
seg_dirorseg_suffix_nameareNone.Refactored the test to use a fixture, should make it easier to modify now.
Remaining issues
N/A.