Add channel normalization and pixel thresholding back #985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
srivarra
approved these changes
May 15, 2023
|
Wait can we not merge this in for now? Discussed with Noah, and we need to pin a new version for my paper that works before we merge this back in. |
|
Also, before we merge this back in, can we get these addressed (in addition to the 3.9 migration), and then a new version pinned for my paper): And can I review the new version before the new pin is created? To avoid what happened last time when a bunch of new things needed to be changed and I asked Sri for a new release like 5 times |
|
@cliu72 version 0.6.4 PR has been merged in with the update Pixie changes, I think this is ready to review. |
cliu72
reviewed
Jul 29, 2023
cliu72
reviewed
Jul 29, 2023
cliu72
reviewed
Jul 29, 2023
cliu72
requested changes
Jul 29, 2023
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
cliu72
reviewed
Aug 1, 2023
cliu72
reviewed
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
Closes #980. Candace's paper has been out for some time now, so we can add these steps back.
How did you implement your changes
Revert to previous state with channel normalization and pixel thresholding.