Kmeans plotting cell border fix #978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngreenwald
approved these changes
Apr 25, 2023
alex-l-kong
added a commit
that referenced
this pull request
May 3, 2023
This reverts commit 4480d9b.
ngreenwald
pushed a commit
that referenced
this pull request
May 3, 2023
* Skip spatial LDA visualization test (Numpy incompatibility) * Remove pros calls as well * Revert "Kmeans plotting cell border fix (#978)" This reverts commit 4480d9b. * Fix numpy < 1.24 to prevent spatial-lda np.float bug (issue open on calico) * Go back to interpolation='none' * Revert "Remove pros calls as well" This reverts commit 271482c. * Revert "Skip spatial LDA visualization test (Numpy incompatibility)" This reverts commit afb2acc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Closes #967.
How did you implement your changes
Added
interpolation='none'to the plt.imshow() call.Remaining issues
NA