Deprecate use of cluster, metacluster, and mc_name outside of remapping #950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
The example dataset version will be changed to main just before merging in. |
|
Same, adding the |
ngreenwald
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR?
Closes #846. It's much easier for the user to read
pixel_som_clusteras opposed tocluster,pixel_meta_clusteras opposed tometacluster, andpixel_meta_cluster_renameas opposed tomc_name. We had used these as a result of standards Zak used, but these names should be reverted outside of the remapping process.How did you implement your changes
Any function outside of
metacluster_remap_guineeds to use the new standard of column naming. When the mapping is saved after a click event ofNew metaclusterhappens, the columns get renamed prior to the save.