Skip to content

Conversation

srivarra
Copy link
Contributor

@srivarra srivarra commented Mar 3, 2023

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Closes #880.

Allows stitching TMAs / images where the row and column count can be greater than 10.

How did you implement your changes

Adjusted the regex for stitch_images_by_shape, adjusted tests.

Remaining issues

@srivarra srivarra linked an issue Mar 3, 2023 that may be closed by this pull request
@srivarra srivarra added the bug Something isn't working label Mar 3, 2023
@srivarra srivarra self-assigned this Mar 3, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@srivarra srivarra changed the title Stitching Large TMAs Stitching Large Images Mar 3, 2023
@srivarra srivarra marked this pull request as ready for review March 23, 2023 17:58
@srivarra srivarra requested a review from camisowers March 23, 2023 18:00
Copy link
Contributor

@camisowers camisowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!

.venv
.venv/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's going on here?

Copy link
Contributor Author

@srivarra srivarra Mar 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use local python virtual environments and if I don't gitignore them, it can slow down git, or mistakenly add a bunch of files.

@srivarra srivarra requested a review from camisowers March 28, 2023 21:53
@srivarra srivarra added this pull request to the merge queue Mar 28, 2023
Merged via the queue into main with commit ac64b0e Mar 28, 2023
@srivarra srivarra deleted the stitching_ranges branch March 28, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stitch_images_by_shape function list index out of range error
2 participants