-
Notifications
You must be signed in to change notification settings - Fork 30
Stitching Large Images #939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good!
.venv | ||
.venv/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's going on here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I use local python virtual environments and if I don't gitignore them, it can slow down git, or mistakenly add a bunch of files.
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Closes #880.
Allows stitching TMAs / images where the row and column count can be greater than 10.
How did you implement your changes
Adjusted the regex for
stitch_images_by_shape
, adjusted tests.Remaining issues