Skip to content

Conversation

srivarra
Copy link
Contributor

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Closes #931.
How did you implement your changes

Adds merge queue, removes python Dependabot.

Remaining issues

N/A.

@srivarra srivarra linked an issue Feb 18, 2023 that may be closed by this pull request
@srivarra srivarra self-assigned this Feb 18, 2023
@srivarra srivarra added the github_actions Pull requests that update GitHub Actions code label Feb 18, 2023
@srivarra srivarra marked this pull request as ready for review February 18, 2023 00:22
@srivarra srivarra requested a review from ngreenwald February 21, 2023 18:54
@ngreenwald
Copy link
Member

I think we’ll need to tweak readthedocs as well? Did you take a look at what’s required there?

@srivarra
Copy link
Contributor Author

@ngreenwald What did we need to tweak for readthedocs? It seems to be building properly. Is it the older package requirements that it uses?

Copy link
Member

@ngreenwald ngreenwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it doesn't work with merge queues. Let's see how it goes.

@ngreenwald ngreenwald added this pull request to the merge queue Feb 21, 2023
@ngreenwald
Copy link
Member

Test failed because out of disk space. You can also see that it's currently waiting for the RTD to build.
image

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 21, 2023
@srivarra
Copy link
Contributor Author

srivarra commented Feb 21, 2023

@ngreenwald Tried to restart the CI workflow in the merge queue, however there was no response coming from the workflow request (probably b/c there's no space). After 12 min of no responses it kicked the PR off the merge queue. Alex's latest 2 run also did not start successfully. It's also odd that readthedocs doesn't build.

@ngreenwald ngreenwald merged commit 3908903 into main Feb 21, 2023
@ngreenwald ngreenwald deleted the github_actions/merge_queue branch February 21, 2023 21:19
@ngreenwald
Copy link
Member

I merged this in, so at least the GA part of the merge queue will be working. RTD doesn't know to look for a merge queue. There's a description in the link I posted in the issue about what to do for non-GA integration.

Separately, we'll need to free up space on GA

@srivarra srivarra added the enhancement New feature or request label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable CI workflow to mesh with merge queue
2 participants