Skip to content

Verify Functions account for lists of size 0 and None #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2023
Merged

Verify Functions account for lists of size 0 and None #25

merged 2 commits into from
Apr 10, 2023

Conversation

srivarra
Copy link
Contributor

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

Closes #19.

How did you implement your changes

Added some logic for handling None values and lists of size 0.

Remaining issues

N/A

@srivarra srivarra added the bug Something isn't working label Mar 13, 2023
@srivarra srivarra self-assigned this Mar 13, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4409978755

  • 20 of 20 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 96.899%
Totals Coverage Status
Change from base Build 4388680983: 0.1%
Covered Lines: 438
Relevant Lines: 450
💛 - Coveralls

@srivarra srivarra marked this pull request as ready for review March 13, 2023 22:11
@srivarra srivarra requested a review from alex-l-kong March 13, 2023 22:11
alex-l-kong
alex-l-kong approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@alex-l-kong alex-l-kong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srivarra srivarra merged commit 553b4c5 into main Apr 10, 2023
@srivarra srivarra deleted the verify_list_size_0 branch April 10, 2023 17:51
@camisowers camisowers mentioned this pull request May 4, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-l-kong alex-l-kong alex-l-kong approved these changes

Assignees

@srivarra srivarra

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

verify_in_list and verify_same_elements should handle lists of size 0, and None
3 participants
@srivarra @coveralls @alex-l-kong