Skip to content

Add dart support #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 31, 2022
Merged

Add dart support #919

merged 10 commits into from
Mar 31, 2022

Conversation

ericlarssen-wf
Copy link
Contributor

@ericlarssen-wf ericlarssen-wf commented Mar 24, 2022

  • Add Dartlang / Pubspec.lock support
  • Can be found in either docker image layer or directory

Signed-off-by: Eric Larssen eric.larssen@workiva.com

@ericlarssen-wf ericlarssen-wf force-pushed the add-dart-support branch 2 times, most recently from 3e62836 to 72a6e35 Compare March 28, 2022 20:43
@ericlarssen-wf ericlarssen-wf marked this pull request as ready for review March 28, 2022 20:58
@wagoodman
Copy link
Contributor

wagoodman commented Mar 30, 2022

Since this introduces a new metadata type we'll need to generate a new json schema. To do that you'll need to:

This will create a new json schema file with the right version.

Copy link
Contributor

@wagoodman wagoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ericlarssen-wf for adding dart support --this is great! I left a few consistency comments, a question about pub lock files, and also noted the need to bump the JSON schema.

@ericlarssen-wf
Copy link
Contributor Author

I was not able to reproduce this issue locally, is there some kind of cache I need to clear?

@wagoodman
Copy link
Contributor

Diff of latest json schema to the changes in this PR (helpful for other reviewers):

diff schema-3.2.1.json schema-3.2.2.json
164a165,186
>     "DartPubMetadata": {
>       "required": [
>         "name",
>         "version"
>       ],
>       "properties": {
>         "name": {
>           "type": "string"
>         },
>         "version": {
>           "type": "string"
>         },
>         "hosted_url": {
>           "type": "string"
>         },
>         "vcs_url": {
>           "type": "string"
>         }
>       },
>       "additionalProperties": true,
>       "type": "object"
>     },
665a688,690
>               "$ref": "#/definitions/DartPubMetadata"
>             },
>             {

ericlarssen-wf and others added 10 commits March 31, 2022 14:58
Signed-off-by: Eric Larssen <eric.larssen@workiva.com>
Signed-off-by: Eric Larssen <eric.larssen@workiva.com>
Signed-off-by: Eric Larssen <eric.larssen@workiva.com>
Signed-off-by: Eric Larssen <eric.larssen@workiva.com>
Signed-off-by: Eric Larssen <eric.larssen@workiva.com>
catalogers

Signed-off-by: Eric Larssen <eric.larssen@workiva.com>
Signed-off-by: Eric Larssen <eric.larssen@workiva.com>
Signed-off-by: Eric Larssen <eric.larssen@workiva.com>
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
@wagoodman
Copy link
Contributor

I force pushed to rebase + fix the merge conflict I caused with the readme update.

Copy link
Contributor

@wagoodman wagoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid addition -- thanks for adding a new language + packaging ecosystem!

@wagoodman wagoodman merged commit cb3e73e into anchore:main Mar 31, 2022
@wagoodman wagoodman added the enhancement New feature or request label Mar 31, 2022
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
Co-authored-by: Alex Goodman <alex.goodman@anchore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants