-
Notifications
You must be signed in to change notification settings - Fork 693
Add dart support #919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dart support #919
Conversation
3e62836
to
72a6e35
Compare
Since this introduces a new metadata type we'll need to generate a new json schema. To do that you'll need to:
This will create a new json schema file with the right version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ericlarssen-wf for adding dart support --this is great! I left a few consistency comments, a question about pub lock files, and also noted the need to bump the JSON schema.
I was not able to reproduce this issue locally, is there some kind of cache I need to clear? |
Diff of latest json schema to the changes in this PR (helpful for other reviewers): diff schema-3.2.1.json schema-3.2.2.json
164a165,186
> "DartPubMetadata": {
> "required": [
> "name",
> "version"
> ],
> "properties": {
> "name": {
> "type": "string"
> },
> "version": {
> "type": "string"
> },
> "hosted_url": {
> "type": "string"
> },
> "vcs_url": {
> "type": "string"
> }
> },
> "additionalProperties": true,
> "type": "object"
> },
665a688,690
> "$ref": "#/definitions/DartPubMetadata"
> },
> {
|
Signed-off-by: Eric Larssen <eric.larssen@workiva.com>
Signed-off-by: Eric Larssen <eric.larssen@workiva.com>
Signed-off-by: Eric Larssen <eric.larssen@workiva.com>
Signed-off-by: Eric Larssen <eric.larssen@workiva.com>
Signed-off-by: Eric Larssen <eric.larssen@workiva.com>
catalogers Signed-off-by: Eric Larssen <eric.larssen@workiva.com>
Signed-off-by: Eric Larssen <eric.larssen@workiva.com>
Signed-off-by: Eric Larssen <eric.larssen@workiva.com>
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
0adaf8b
to
b8307ea
Compare
I force pushed to rebase + fix the merge conflict I caused with the readme update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid addition -- thanks for adding a new language + packaging ecosystem!
Co-authored-by: Alex Goodman <alex.goodman@anchore.com>
Signed-off-by: Eric Larssen eric.larssen@workiva.com