fix: support multiple letters in openssl patch version #4106
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: honigbot <thesoftbear@gmail.com>
|
I would kindly request and appreciate a review maintainers. Is there something I can do to support with that? |
hawkaii
pushed a commit
to hawkaii/syft
that referenced
this pull request
Aug 14, 2025
Signed-off-by: honigbot <thesoftbear@gmail.com> Signed-off-by: Parthib Mukherjee <parthibmukherjee@gmail.com>
spiffcs
added a commit
that referenced
this pull request
Aug 18, 2025
* main: chore(deps): bump github.com/hashicorp/go-getter from 1.7.8 to 1.7.9 (#4144) chore(deps): bump anchore/sbom-action from 0.20.4 to 0.20.5 (#4141) chore(deps): update tools to latest versions (#4139) feat: add support for authors, maintainers, and contributors in package.json. (#4003) chore(deps): bump zizmorcore/zizmor-action from 0.1.1 to 0.1.2 (#4135) feat: add package supplier flag (#4131) feat: update syft license construction to be able to look up by URL (#4132) chore(deps): bump github/codeql-action from 3.29.8 to 3.29.9 (#4134) fix: support multiple letters in openssl patch version (#4106) fix: closed reader during java binary detection (#4129) chore(deps): bump actions/checkout from 4.2.2 to 5.0.0 (#4130) chore: update GoReleaser configurations (#4128)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some openssl versions have two letter versions. This is not supported by the current binary-classifier regex:
syft/syft/pkg/cataloger/binary/classifiers.go
Line 486 in 801b21b
These two-letter versions are referenced for example here:
Furthermore, grype db lists two-letter versions, but without syft detecting multi-letter versions it generate false positives:
Therefore this patch fixes the pattern to allow multiple letters after the patch level:
Type of change
Checklist: