Add support for authors in package.json. Fixes #2250 #4003
Merged
+347
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Pope <alan.pope@anchore.com>
kzantow
reviewed
Jun 13, 2025
Signed-off-by: Alan Pope <alan.pope@anchore.com>
2c9486a to
7c154ba
Compare
This change helps us cover maintainers and contributros if they exist. These fields follow the same structured or stringified pattern that authors does. Signed-off-by: Christopher Phillips <32073428+spiffcs@users.noreply.github.com>
|
Kicked the tires on this one and added support for maintainers and contributors as well |
spiffcs
approved these changes
Aug 13, 2025
|
@popey huge 🥳 for this one. Sorry for the lag and glad this is making it's way forward. Will baby sit to get this in no more needed from other authors or maintainers. |
hawkaii
pushed a commit
to hawkaii/syft
that referenced
this pull request
Aug 14, 2025
…ge.json. (anchore#4003) Fixes anchore#2250 --------- Signed-off-by: Alan Pope <alan.pope@anchore.com> Signed-off-by: Christopher Phillips <32073428+spiffcs@users.noreply.github.com> Co-authored-by: Christopher Phillips <32073428+spiffcs@users.noreply.github.com> Signed-off-by: Parthib Mukherjee <parthibmukherjee@gmail.com>
spiffcs
added a commit
that referenced
this pull request
Aug 18, 2025
* main: chore(deps): bump github.com/hashicorp/go-getter from 1.7.8 to 1.7.9 (#4144) chore(deps): bump anchore/sbom-action from 0.20.4 to 0.20.5 (#4141) chore(deps): update tools to latest versions (#4139) feat: add support for authors, maintainers, and contributors in package.json. (#4003) chore(deps): bump zizmorcore/zizmor-action from 0.1.1 to 0.1.2 (#4135) feat: add package supplier flag (#4131) feat: update syft license construction to be able to look up by URL (#4132) chore(deps): bump github/codeql-action from 3.29.8 to 3.29.9 (#4134) fix: support multiple letters in openssl patch version (#4106) fix: closed reader during java binary detection (#4129) chore(deps): bump actions/checkout from 4.2.2 to 5.0.0 (#4130) chore: update GoReleaser configurations (#4128)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for parsing the
authorsfield inpackage.jsonfiles. Previously, Syft only recognized the singularauthorfield, but the npm ecosystem supports both formats. This change ensures that Syft properly parses both formats and combines them when both are present in apackage.jsonfile.The implementation:
authors []authortype to handle the plural formUnmarshalJSONto handle parsing different formats (array of strings or objects)AuthorsString()to convert authors array to a properly formatted stringnewPackageJSONPackageto handle both fields appropriatelyThis change improves the accuracy of npm package metadata parsing in Syft.
Type of change
Checklist: