Do not search for main module versions within binary contents by default #3874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzantow
approved these changes
May 9, 2025
Signed-off-by: Alex Goodman <wagoodman@users.noreply.github.com>
spiffcs
added a commit
that referenced
this pull request
May 13, 2025
* main: Translate Portage license strings to SPDX expressions (#1763) fix: stop emitting redis redis CPE for PHP PECL redis (#3881) feat: Add PURL list input/output format (#3853) chore(deps): update CPE dictionary index (#3877) chore(deps): update tools to latest versions (#3878) do not search binary contents for version for go package (#3874) fix: remove race when writing errors in generic cataloger (#3875) clear devel version for go packages (#3873) Signed-off-by: Christopher Phillips <32073428+spiffcs@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today if no version can be found for a go module within a binary (searching buildinfo or ldflags) then a semver regex is applied to the full contents of the binary. This is costly resource-wise and often raises incorrect versions. For this reason this PR makes this behavior opt-in only.
Type of change
Checklist
PR Stack
(devel)version from go main modules #3873