Retry auth URL lookup without docker credentialhelper workaround #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <alex.goodman@anchore.com>
Benchmark Test ResultsBenchmark results from the latest changes vs base branch |
spiffcs
approved these changes
Apr 6, 2022
spiffcs
reviewed
Apr 6, 2022
| ref, err := name.ParseReference(imageStr) | ||
| if err != nil { | ||
| return "", err | ||
| } | ||
|
|
||
| url := ref.Context().RegistryStr() | ||
| if url == "index.docker.io" { | ||
| if dockerhubWorkaround && url == "index.docker.io" { | ||
| // why do this? There is an upstream issue here: https://github.com/docker/docker-credential-helpers/blob/e595cd69465c6b0f7af2d49582b82fdeddecbf75/wincred/wincred_windows.go#L113-L127 |
There was a problem hiding this comment.
For people coming to this PR. This comment gives a lot of the context as to why this whole daemon provider works the way it does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses anchore/syft#936
This PR builds on #120, where we tailor URLs for dockerhub when authenticating against the registry (via the docker daemon), however, this original change was meant to fix behavior when using the credential helpers. This change regressed behavior for users that have
authentries directly in the~/.docker/config.json. This PR changes the auth behavior to search for credentials with the credentials workaround first, and if not found, then fallback behavior is to try the credential search again with the original url.