Skip to content

Allow type "file:..." to enable creation of SBOMs from tar and other package formats #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2022
Merged

Allow type "file:..." to enable creation of SBOMs from tar and other package formats #357

merged 1 commit into from
Oct 5, 2022

Conversation

malt3
Copy link
Contributor

@malt3 malt3 commented Oct 1, 2022

Signed-off-by: Malte Poll mp@edgeless.systems

kzantow
kzantow reviewed Oct 3, 2022
View reviewed changes
Copy link
Contributor

@kzantow kzantow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @malt3, thanks for the submission! I think to be consistent we should probably add a file parameter, which is mutually exclusive to image and path instead of having the path double as both dir and file. Would this work for you?

@malt3
Copy link
Contributor Author

malt3 commented Oct 3, 2022

Sure thing. It sounds a little bit confusing to have path which resolves to dir: and file which resolves to file: but renaming the existing parameter is probably even worse as it is breaking change.
What do you think about keeping path -> dir: for backwards compat and adding both file -> file: and dir -> dir: as parameters?
Just a suggestion. I can implement this any way you like :)

@kzantow
Copy link
Contributor

kzantow commented Oct 3, 2022

@malt3 I think keeping path -> dir: and adding a file -> file: is the right thing to do for now. NOTE: these are syft conventions that haven't actually been set it stone, so we chose path. I agree it seems perhaps a bit ambiguous, but to avoid breaking changes, I suggest just adding the file option (and, of course updating the documentation/action config/etc. to reflect this).

kzantow
kzantow reviewed Oct 4, 2022
View reviewed changes
kzantow
kzantow reviewed Oct 5, 2022
View reviewed changes
@malt3
Allow type "file:..."
ea032bd 
Signed-off-by: Malte Poll <mp@edgeless.systems>
@kzantow kzantow closed this Oct 5, 2022
@kzantow kzantow reopened this Oct 5, 2022
@kzantow
Copy link
Contributor

kzantow commented Oct 5, 2022

@malt3 thanks for the contribution -- this looks good, I just need to get a successful run of the tests. I'm not sure why they haven't run yet... It appears GH may be having some issues with actions at the moment. I'll try to get them kicked off later today.

@kzantow kzantow closed this Oct 5, 2022
@kzantow kzantow reopened this Oct 5, 2022
@kzantow kzantow merged commit 614fe8a into anchore:main Oct 5, 2022
@felickz felickz mentioned this pull request Oct 28, 2022
Closed
@felickz
Copy link

felickz commented Oct 31, 2022

This PR was pushed with 0.13.0 but not seeing the file property being observed: #383 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kzantow kzantow kzantow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malt3 @kzantow @felickz