Fix rollup incompatibility, fix test failure #1208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses build and test failures caused by rollup plugin incompatibility by updating dependency versions and converting all TypeScript imports to include a “.js” extension in compliance with the newer ECMAScript module standards. In addition, the PR updates tsconfig settings (using nodenext and allowing TS extension imports) and revises test callbacks to use Promise‑resolution instead of t.end().
Reviewed Changes
Copilot reviewed 284 out of 287 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/worker-thread/tsconfig.json | Updated module resolution and target to “nodenext” with additional TS flag |
| Various source files | All import statements now include “.js” extensions to match ESM conventions |
| Multiple test files | Modified test callbacks to return Promises instead of using t.end() |
Comments suppressed due to low confidence (1)
src/worker-thread/tsconfig.json:10
- The tsconfig.json has been updated to use 'nodenext' and includes 'allowImportingTsExtensions'. Please verify that these changes are fully compatible with your build process and dependency chain.
"module": "nodenext",
erwinmombay
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build has been broken and
npm installhas not been working due to rollup plugin versions incompatible. Had to change to the newer version.ava@3 no longer works with the dependencies. Tests always fail due to importing esm from dependencies. I had to upgrade to ava@6. This forces me to fix the ts imports since it is failing various tests. This PR seems to be the easiest way to fix it. It basically changes all imports to
import xxx from 'xxx.js';tsconfig is changed to module. Unit tests that use
cbhave been deprecated in ava, so I updated them to the promise-style tests.I cannot neatly split it into PRs, since nothing is going to build till everything gets fixed.