Unsubscription/removing "on" listener must not cause an error #1148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
d0c4362 to
0da4f4a
Compare
olitvinenko
approved these changes
Jul 5, 2023
powerivq
requested changes
Aug 9, 2023
src/worker-thread/dom/HTMLElement.ts
Outdated
| @@ -22,7 +22,9 @@ export const appendGlobalEventProperties = (keys: Array<string>): void => { | |||
| if (stored) { | |||
| this.removeEventListener(normalizedKey, stored); | |||
| } | |||
| this.addEventListener(normalizedKey, value); | |||
| if (typeof value === 'function') { | |||
There was a problem hiding this comment.
Can we do value instanceof Function?
0da4f4a to
f4269e0
Compare
f4269e0 to
7b61196
Compare
powerivq
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing of event listener with in a way like:
element.onclick = null;, storesnullas a handler.