Consolidate prettier #1066
Merged
Consolidate prettier #1066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
759eb2d to
fce9291
Compare
|
No solid thoughts on consolidating the prettier configurations, but can we keep the line length the same as it was? |
3cd6d7f to
d24c490
Compare
|
I personally care much more about consolidating the files and moving to toplevel to let my IDE pick it up and less so about the specific prettier options. Therefore I've elected to pick a configuration that has the fewest changes (same line length, bracket spacing, etc.). If anyone has specific ideas of what formatting they prefer, feel free to open a followup PR. |
kristoferbaxter
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
config/.prettierrc,tools/linter/.prettierrc, andtools/linter/config/.prettierrc. It adds a root-level config, and also removes the printWidth option. I personally prefer root-level because thenprettiercan find it without a --config flag, as well as VSCode.srcandtoolsdirs.