Skip to content

nodom: support storage #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 23, 2021
Merged

nodom: support storage #1064

merged 7 commits into from
Jun 23, 2021

Conversation

samouri
Copy link
Member

@samouri samouri commented Jun 9, 2021

summary
The nodom binary historically hasn't called hydrate since there is no DOM to hydrate. What I didn't realize at the time was the LocalStorage and SessionStorage are also initialized during hydration.

  • This PR adds in storage support for nodom binaries.
  • It also extracts storage init to its own file to avoid dragging along all of Document (which in turn pulls in the vdom)

@samouri samouri self-assigned this Jun 15, 2021
@samouri samouri marked this pull request as ready for review June 15, 2021 20:14
@samouri samouri requested a review from kristoferbaxter June 15, 2021 20:48
@kristoferbaxter kristoferbaxter merged commit 5d4d4c9 into main Jun 23, 2021
@rcebulko rcebulko deleted the localStorage branch June 23, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants