Skip to content

refactor(client): updated tooltips #8849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

p1kalys
Copy link
Contributor

@p1kalys p1kalys commented Aug 8, 2024

Close: #8806

PR Details

Refactored the tooltips to avoid talking about node.js only

PR Checklist

  • [✅] Tests for the changes have been added
  • [✅] npm test doesn't throw any error

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@p1kalys
Copy link
Contributor Author

p1kalys commented Aug 9, 2024

Hey @PazYanoverr, Any other changes required for this issue?

@PazYanoverr
Copy link
Contributor

Hi @p1kalys,
Reviewed it, and it LGTM.
@morhag90 - Can you please review and push to next? (@mulygottlieb - FYI)

@PazYanoverr PazYanoverr requested a review from morhag90 August 11, 2024 12:44
@p1kalys
Copy link
Contributor Author

p1kalys commented Aug 22, 2024

Hi Team, any update on this PR?

@PazYanoverr
Copy link
Contributor

@mulygottlieb @morhag90 - Can you assist please?

@mulygottlieb mulygottlieb changed the base branch from master to next August 22, 2024 10:39
Copy link

nx-cloud bot commented Aug 22, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c7dac67. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@mulygottlieb mulygottlieb merged commit 6292517 into amplication:next Aug 22, 2024
9 checks passed
@mulygottlieb
Copy link
Contributor

Thanks for your contribution @p1kalys !
Approved and merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the tooltips of the Overview metrics to avoid talking about Node.js only
5 participants