Merge/4055 #4128
Merged
Merge/4055 #4128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion-nest-logger-module-amplification-git-service use amplication nest logger module in amplication-git-service
|
community PR. |
|
@overbit @arielweinberger please review. |
# Conflicts: # libs/data-service-generator/package-lock.json # packages/amplication-git-service/package.json # packages/amplication-git-service/src/git.module.ts # packages/amplication-git-service/src/utils/constants.ts
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 020195c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 5 targetsSent with 💌 from NxCloud. |
|
I am closing this PR due to inactivity |
|
@yuval-hazaz I actually fix the conflicts yesterday, I'll reopen it. |
yuval-hazaz
approved these changes
Jan 22, 2023
|
@overbit please, don't forget to link PR to the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #3396
PR Details
PR Checklist
npm testdoesn't throw any errorIMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.