Skip to content

Add InternetAddress::tryFromString() #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2023
Merged

Add InternetAddress::tryFromString() #105

merged 1 commit into from
Apr 6, 2023

Conversation

trowski
Copy link
Member

@trowski trowski commented Apr 6, 2023

This PR adds InternetAddress::tryFromString(), which is similar to fromString(), accept it returns null instead of throwing.

Seems we were a bit inconsistent with throwing SocketException vs. ValueError for invalid portions of the address. I changed them all to SocketException. I think this should be fine, since we declared the constructor and fromString as throwing SocketException on an invalid address.

@kelunik kelunik merged commit 70a72fb into 2.x Apr 6, 2023
@kelunik kelunik deleted the 2.x-try-internet-address branch April 6, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelunik kelunik kelunik approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trowski @kelunik